You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current CMake script that is used to find NumPy does not always work for me, and sometimes causes problems on the different systems I build on. Given we have recently updated the minimum CMake version and the minimum pybind11 version, these changes now use the standard CMake tools to find Python3 and NumPy, and makes the links with the standard CMake targets. I specifically use Python3 in the CMake as the indicated pybind11 version no longer supports Python 2.7.
I know it has taken me a bit to figure out the exact linking needed for the tests, but now, the current test failures seem to be due to the test environment not having the libpython3.so available:
CMake Error at /home/runner/micromamba/envs/xtensor-python/share/cmake-4.4/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
Could NOT find Python3 (missing: Python3_LIBRARIES Development.Embed)
(found version "3.15.0")
Looking at this link, it appears that starting with Python 3.15, the python package in conda no longer provides libpython3.so, and you must add the libpython package as well. The error message seems to support this, as it found a 3.15 interpreter, but not the dynamic library. I don't think any tests have been run on this repo since python 3.15 came out ? Because I think if the pipeline on master were to be re-run, you would find that tests are broken due to this issue. To fix this, I am going to just specify python and libpython as dependencies in environment-dev.yml to try and fix the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CMake script that is used to find NumPy does not always work for me, and sometimes causes problems on the different systems I build on. Given we have recently updated the minimum CMake version and the minimum pybind11 version, these changes now use the standard CMake tools to find Python3 and NumPy, and makes the links with the standard CMake targets. I specifically use Python3 in the CMake as the indicated pybind11 version no longer supports Python 2.7.